[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=405154&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-405154
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Mar/20 02:29
Start Date: 18/Mar/20 02:29
Worklog Time Spent: 10m
Work Description: udim commented on pull request #11038: [BEAM-7746] More
typing fixes
URL: https://github.com/apache/beam/pull/11038#discussion_r394057261
##########
File path: sdks/python/apache_beam/runners/worker/sdk_worker.py
##########
@@ -171,7 +172,7 @@ def get_responses():
self._worker_thread_pool.shutdown()
# get_responses may be blocked on responses.get(), but we need to return
# control to its caller.
- self._responses.put(no_more_work)
+ self._responses.put(no_more_work) # type: ignore[arg-type]
Review comment:
Sounds like a good idea. There are ~20 places in the code that assign
`object()` as value.
One of them is even called `READER_THREAD_IS_DONE_SENTINEL`. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 405154)
Time Spent: 76h 40m (was: 76.5h)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 76h 40m
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
