[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=405141&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-405141
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Mar/20 02:29
Start Date: 18/Mar/20 02:29
Worklog Time Spent: 10m
Work Description: udim commented on pull request #11038: [BEAM-7746] More
typing fixes
URL: https://github.com/apache/beam/pull/11038#discussion_r393304392
##########
File path: sdks/python/mypy.ini
##########
@@ -17,16 +17,21 @@
[mypy]
python_version = 3.6
+files = apache_beam
ignore_missing_imports = true
-follow_imports = true
-warn_no_return = true
no_implicit_optional = true
+# warnings:
+warn_no_return = true
warn_redundant_casts = true
warn_unused_ignores = true
+# formatting:
show_error_codes = true
-files = apache_beam
color_output = true
-# uncomment this to see how close we are to being complete
+# required setting for dmypy:
+follow_imports = error
Review comment:
Does this mean having to supply all imported modules on the mypy command
line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 405141)
Time Spent: 75h 40m (was: 75.5h)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 75h 40m
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
