[
https://issues.apache.org/jira/browse/BEAM-1819?focusedWorklogId=406295&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-406295
]
ASF GitHub Bot logged work on BEAM-1819:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Mar/20 14:55
Start Date: 19/Mar/20 14:55
Worklog Time Spent: 10m
Work Description: rehmanmuradali commented on issue #11154: [BEAM-1819]
Key should be available in @OnTimer methods
URL: https://github.com/apache/beam/pull/11154#issuecomment-601225409
> Could we ensure that the FnApiDoFnRunner implementation for the key is
completed as well?
> I think the type check for `@KeyId` breaks if the key is generic. I was
trying this out and got:
>
> ```
> java.lang.IllegalArgumentException: CombinerDoFn, @OnTimer
onTriggerTimer(BoundedWindow, WindowedKey, CombiningState, CombiningState,
ValueState, CombiningState, BagState, OutputReceiver): @Key argument is
expected to be type of WindowedKey<K>, but found class WindowedKey
> ```
Thank you @steveniemitz for catching this bug. Can you please mention how
can I reproduce it so that I can fix this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 406295)
Time Spent: 7h (was: 6h 50m)
> Key should be available in @OnTimer methods
> -------------------------------------------
>
> Key: BEAM-1819
> URL: https://issues.apache.org/jira/browse/BEAM-1819
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Thomas Groh
> Assignee: Shehzaad Nakhoda
> Priority: Major
> Time Spent: 7h
> Remaining Estimate: 0h
>
> Every timer firing has an associated key. This key should be available when
> the timer is delivered to a user's {{DoFn}}, so they don't have to store it
> in state.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
