[
https://issues.apache.org/jira/browse/BEAM-1819?focusedWorklogId=406376&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-406376
]
ASF GitHub Bot logged work on BEAM-1819:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Mar/20 16:33
Start Date: 19/Mar/20 16:33
Worklog Time Spent: 10m
Work Description: steveniemitz commented on issue #11154: [BEAM-1819] Key
should be available in @OnTimer methods
URL: https://github.com/apache/beam/pull/11154#issuecomment-601280654
so I think this was enough to get it working in dataflow:
```
diff --git
a/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/SimpleParDoFn.java
b/runners/google-cloud-dataflow-j
ava/worker/src/main/java/org/apache/beam/runners/dataflow/worker/SimpleParDoFn.java
index 2c96736..96ce156 100644
---
a/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/SimpleParDoFn.java
+++
b/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/SimpleParDoFn.java
@@ -373,7 +373,7 @@ public class SimpleParDoFn<InputT, OutputT> implements
ParDoFn {
fnRunner.onTimer(
timer.getTimerId(),
timer.getTimerFamilyId(),
- "",
+ this.stepContext.stateInternals().getKey(),
window,
timer.getTimestamp(),
timer.getOutputTimestamp(),
diff --git
a/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java
b/runners/google-cloud-
dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java
index 1ecdd50..04e4b15 100644
---
a/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java
+++
b/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java
@@ -123,6 +123,7 @@ import
org.apache.beam.runners.dataflow.worker.windmill.WindmillServerStub.Commi
import
org.apache.beam.runners.dataflow.worker.windmill.WindmillServerStub.GetWorkStream;
import
org.apache.beam.runners.dataflow.worker.windmill.WindmillServerStub.StreamPool;
import org.apache.beam.sdk.coders.Coder;
+import org.apache.beam.sdk.coders.KvCoder;
import org.apache.beam.sdk.extensions.gcp.util.Transport;
import org.apache.beam.sdk.fn.IdGenerator;
import org.apache.beam.sdk.fn.IdGenerators;
@@ -1365,6 +1366,10 @@ public class StreamingDataflowWorker {
// Note that TimerOrElementCoder is a backwards-compatibility class
// that is really a FakeKeyedWorkItemCoder
Coder<?> valueCoder = ((WindowedValueCoder<?>)
readCoder).getValueCoder();
+
+ if (valueCoder instanceof KvCoder<?, ?>) {
+ return ((KvCoder<?, ?>) valueCoder).getKeyCoder();
+ }
if (!(valueCoder instanceof
WindmillKeyedWorkItem.FakeKeyedWorkItemCoder<?, ?>)) {
return null;
}
```
cc @reuvenlax on the worker changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 406376)
Time Spent: 8h (was: 7h 50m)
> Key should be available in @OnTimer methods
> -------------------------------------------
>
> Key: BEAM-1819
> URL: https://issues.apache.org/jira/browse/BEAM-1819
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Thomas Groh
> Assignee: Shehzaad Nakhoda
> Priority: Major
> Time Spent: 8h
> Remaining Estimate: 0h
>
> Every timer firing has an associated key. This key should be available when
> the timer is delivered to a user's {{DoFn}}, so they don't have to store it
> in state.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
