[
https://issues.apache.org/jira/browse/BEAM-9562?focusedWorklogId=408826&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408826
]
ASF GitHub Bot logged work on BEAM-9562:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Mar/20 14:57
Start Date: 24/Mar/20 14:57
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #11199: [BEAM-9562]
Update Timer encoding to V2
URL: https://github.com/apache/beam/pull/11199#discussion_r397213244
##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -718,9 +726,15 @@ message StandardCoders {
// 1: 80 00 00 00 00 00 00 01
// 256: 80 00 00 00 00 00 01 00
// 9223372036854775807: FF FF FF FF FF FF FF FF
- // payload - user defined data, uses the component coder
- // Components: Coder for the payload.
- TIMER = 4 [(beam_urn) = "beam:coder:timer:v1"];
+ //
+ // hold timestamp - similar to fire timestamp, but stands for the
+ // watermark the timer is expected to hold.
+ //
+ // windows - uses the component coder.
+ //
+ // paneinfo - similar to how paneinfo gets encoded in WindowedValue.
+ // Components: Coder for the user key, coder for the windows,
+ TIMER = 4 [(beam_urn) = "beam:coder:timer:v2"];
Review comment:
You don't need to change this to v2 since these are not stable yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 408826)
Time Spent: 1.5h (was: 1h 20m)
> Remove timer from PCollection and treat timers as Elements
> -----------------------------------------------------------
>
> Key: BEAM-9562
> URL: https://issues.apache.org/jira/browse/BEAM-9562
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-harness
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
