[
https://issues.apache.org/jira/browse/BEAM-9562?focusedWorklogId=408825&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408825
]
ASF GitHub Bot logged work on BEAM-9562:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Mar/20 14:57
Start Date: 24/Mar/20 14:57
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #11199: [BEAM-9562]
Update Timer encoding to V2
URL: https://github.com/apache/beam/pull/11199#discussion_r397214242
##########
File path: model/fn-execution/src/main/proto/beam_fn_api.proto
##########
@@ -609,16 +609,20 @@ message Elements {
// represents the producer of these timers.
string transform_id = 2;
+ // (Optional) The local timer family name used to identify the associated
+ // timer family specification
+ string timer_family_tag = 3;
Review comment:
`timer_id` == `timer_family_tag` since the `timer_id` represents the `key`
from `timer_family_specs`.
Note that we will either need to remove `timer_specs` from ParDoPayload or
ensure that `timer_specs` and `timer_family_specs` don't share any keys.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 408825)
Time Spent: 1.5h (was: 1h 20m)
> Remove timer from PCollection and treat timers as Elements
> -----------------------------------------------------------
>
> Key: BEAM-9562
> URL: https://issues.apache.org/jira/browse/BEAM-9562
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-harness
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
