[
https://issues.apache.org/jira/browse/BEAM-9136?focusedWorklogId=412848&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-412848
]
ASF GitHub Bot logged work on BEAM-9136:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Mar/20 04:40
Start Date: 31/Mar/20 04:40
Worklog Time Spent: 10m
Work Description: Hannah-Jiang commented on pull request #11243:
[BEAM-9136]Add licenses for dependencies for Java
URL: https://github.com/apache/beam/pull/11243#discussion_r400602453
##########
File path: sdks/java/container/build.gradle
##########
@@ -68,6 +73,25 @@ golang {
}
}
+// this is a workaround to call generateLicenseReport task directly.
+// generateLicenseReport does not return correct dependency list when called
with dependsOn feature.
+task generateThirdPartyLicenses(type: Exec) {
+ workingDir project.rootProject.projectDir
+ commandLine './sdks/java/container/license_script.sh'
+}
+
+//command: ./gradlew generateLicenseReport
+licenseReport {
+ outputDir = 'third_party_licenses'
+ projects = [project.rootProject] + project.rootProject.subprojects
+ excludeOwnGroup = true
+}
+
+task copyThirdPartyLicenses(type: Copy) {
Review comment:
From @alanmyrvold
> Can this task be added to
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy in
applyDockerNature?
I think it's better to keep it with individual language, because Python does
not have this task. (Python writes to /opt/apache/beam/third_party_licenses
directly.) Making this task runs for Java and Go only needs some configurations
and is not as simple as this implementation. Does this sound good?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 412848)
Time Spent: 14h 10m (was: 14h)
> Add LICENSES and NOTICES to docker images
> -----------------------------------------
>
> Key: BEAM-9136
> URL: https://issues.apache.org/jira/browse/BEAM-9136
> Project: Beam
> Issue Type: Task
> Components: build-system
> Reporter: Hannah Jiang
> Assignee: Hannah Jiang
> Priority: Major
> Time Spent: 14h 10m
> Remaining Estimate: 0h
>
> Scan dependencies and add licenses and notices of the dependencies to SDK
> docker images.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
