[
https://issues.apache.org/jira/browse/BEAM-9136?focusedWorklogId=413576&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-413576
]
ASF GitHub Bot logged work on BEAM-9136:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Mar/20 22:31
Start Date: 31/Mar/20 22:31
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #11067:
[BEAM-9136]Add licenses for dependencies for Python
URL: https://github.com/apache/beam/pull/11067#discussion_r401244854
##########
File path: sdks/python/container/Dockerfile
##########
@@ -51,16 +51,20 @@ RUN ln -s /usr/bin/ccache /usr/local/bin/gcc
RUN ccache --set-config=sloppiness=file_macro && ccache
--set-config=hash_dir=false
COPY target/apache-beam.tar.gz /opt/apache/beam/tars/
+ADD target/license_scripts /tmp/license_scripts/
Review comment:
COPY is preferred over ADD. Can we remove usages of ADD to reduce cognitive
load on people who might think why are we using sometimes COPY and sometimes
ADD?
See:
https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#add-or-copy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 413576)
Time Spent: 15h 10m (was: 15h)
> Add LICENSES and NOTICES to docker images
> -----------------------------------------
>
> Key: BEAM-9136
> URL: https://issues.apache.org/jira/browse/BEAM-9136
> Project: Beam
> Issue Type: Task
> Components: build-system
> Reporter: Hannah Jiang
> Assignee: Hannah Jiang
> Priority: Major
> Time Spent: 15h 10m
> Remaining Estimate: 0h
>
> Scan dependencies and add licenses and notices of the dependencies to SDK
> docker images.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
