[
https://issues.apache.org/jira/browse/BEAM-8280?focusedWorklogId=413428&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-413428
]
ASF GitHub Bot logged work on BEAM-8280:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Mar/20 18:16
Start Date: 31/Mar/20 18:16
Worklog Time Spent: 10m
Work Description: angoenka commented on pull request #10717: [BEAM-8280]
Enable type hint annotations
URL: https://github.com/apache/beam/pull/10717#discussion_r401117161
##########
File path: sdks/python/apache_beam/typehints/decorators.py
##########
@@ -138,8 +139,7 @@ def foo((a, b)):
_ANY_VAR_POSITIONAL = typehints.Tuple[typehints.Any, ...]
_ANY_VAR_KEYWORD = typehints.Dict[typehints.Any, typehints.Any]
-# TODO(BEAM-8280): Remove this when from_callable is ready to be enabled.
-_enable_from_callable = False
+_disable_from_callable = False
Review comment:
Should this be True? (based on the check in line 234)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 413428)
Time Spent: 11h 50m (was: 11h 40m)
> re-enable IOTypeHints.from_callable
> -----------------------------------
>
> Key: BEAM-8280
> URL: https://issues.apache.org/jira/browse/BEAM-8280
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Udi Meiri
> Assignee: Udi Meiri
> Priority: Major
> Time Spent: 11h 50m
> Remaining Estimate: 0h
>
> See https://issues.apache.org/jira/browse/BEAM-8279
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
