[
https://issues.apache.org/jira/browse/BEAM-8280?focusedWorklogId=413433&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-413433
]
ASF GitHub Bot logged work on BEAM-8280:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Mar/20 18:18
Start Date: 31/Mar/20 18:18
Worklog Time Spent: 10m
Work Description: udim commented on pull request #10717: [BEAM-8280]
Enable type hint annotations
URL: https://github.com/apache/beam/pull/10717#discussion_r401118829
##########
File path: sdks/python/apache_beam/typehints/decorators.py
##########
@@ -138,8 +139,7 @@ def foo((a, b)):
_ANY_VAR_POSITIONAL = typehints.Tuple[typehints.Any, ...]
_ANY_VAR_KEYWORD = typehints.Dict[typehints.Any, typehints.Any]
-# TODO(BEAM-8280): Remove this when from_callable is ready to be enabled.
-_enable_from_callable = False
+_disable_from_callable = False
Review comment:
No, I inverted the logic and made using type annotations on by default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 413433)
Time Spent: 12h (was: 11h 50m)
> re-enable IOTypeHints.from_callable
> -----------------------------------
>
> Key: BEAM-8280
> URL: https://issues.apache.org/jira/browse/BEAM-8280
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Udi Meiri
> Assignee: Udi Meiri
> Priority: Major
> Time Spent: 12h
> Remaining Estimate: 0h
>
> See https://issues.apache.org/jira/browse/BEAM-8279
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
