[
https://issues.apache.org/jira/browse/BEAM-9618?focusedWorklogId=414361&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-414361
]
ASF GitHub Bot logged work on BEAM-9618:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Apr/20 22:52
Start Date: 01/Apr/20 22:52
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #11235: [BEAM-9618]
Pull bundle descriptors.
URL: https://github.com/apache/beam/pull/11235#discussion_r401954623
##########
File path: sdks/python/apache_beam/runners/worker/sdk_worker.py
##########
@@ -112,7 +113,11 @@ def __init__(self,
self._state_handler_factory = GrpcStateHandlerFactory(
self._state_cache, credentials)
self._profiler_factory = profiler_factory
- self._fns = {} # type: Dict[str, beam_fn_api_pb2.ProcessBundleDescriptor]
+ self._fns = KeyedDefaultDict(
+ lambda id: self._control_stub.GetProcessBundleDescriptor(
+ beam_fn_api_pb2.GetProcessBundleDescriptorRequest(
Review comment:
What appears in the default dict if GetProcessBundleDescriptor raises an
error because the call fails?
Does it get propagated to the caller and it fails processing the bundle (is
anything left in the map)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 414361)
Time Spent: 1h 10m (was: 1h)
> Allow SDKs to pull process bundle descriptors.
> ----------------------------------------------
>
> Key: BEAM-9618
> URL: https://issues.apache.org/jira/browse/BEAM-9618
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
> Reporter: Robert Bradshaw
> Assignee: Robert Bradshaw
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
