[
https://issues.apache.org/jira/browse/BEAM-9618?focusedWorklogId=414358&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-414358
]
ASF GitHub Bot logged work on BEAM-9618:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Apr/20 22:52
Start Date: 01/Apr/20 22:52
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #11235: [BEAM-9618]
Pull bundle descriptors.
URL: https://github.com/apache/beam/pull/11235#discussion_r401948041
##########
File path: sdks/python/apache_beam/runners/worker/sdk_worker_test.py
##########
@@ -115,8 +115,9 @@ def _check_fn_registration_multi_request(self, *args):
{item.id: item
for item in process_bundle_descriptors})
- def test_fn_registration(self):
- self._check_fn_registration_multi_request((1, 4), (4, 4))
+
+# def test_fn_registration(self):
+# self._check_fn_registration_multi_request((1, 4), (4, 4))
Review comment:
if we can, we should test the registration lookup failure case.
The success case will be easily be covered by other tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 414358)
Time Spent: 50m (was: 40m)
> Allow SDKs to pull process bundle descriptors.
> ----------------------------------------------
>
> Key: BEAM-9618
> URL: https://issues.apache.org/jira/browse/BEAM-9618
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
> Reporter: Robert Bradshaw
> Assignee: Robert Bradshaw
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
