[
https://issues.apache.org/jira/browse/BEAM-8019?focusedWorklogId=414416&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-414416
]
ASF GitHub Bot logged work on BEAM-8019:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Apr/20 01:52
Start Date: 02/Apr/20 01:52
Worklog Time Spent: 10m
Work Description: chamikaramj commented on pull request #11185:
[BEAM-8019] Updates Python SDK to handle remote SDK coders and preserve tags
added by remote SDKs and propagate restriction coders.
URL: https://github.com/apache/beam/pull/11185#discussion_r399896870
##########
File path: sdks/python/apache_beam/pipeline.py
##########
@@ -1128,29 +1136,67 @@ def from_runner_api(proto, # type:
beam_runner_api_pb2.PTransform
context # type: PipelineContext
):
# type: (...) -> AppliedPTransform
- def is_side_input(tag):
+ def is_python_side_input(tag):
# type: (str) -> bool
# As per named_inputs() above.
- return tag.startswith('side')
+ return re.match(SIDE_INPUT_REGEX, tag)
Review comment:
I changed the Python side input prefix from 'side' to 'python_side_input'
(SIDE_INPUT_PREFIX) to make this tighter. This is still not 100% fail safe (an
external SDK might still start side input tags with 'python_side_input') but I
don't think this will be an issue in practice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 414416)
Time Spent: 13h 20m (was: 13h 10m)
> Support cross-language transforms for DataflowRunner
> ----------------------------------------------------
>
> Key: BEAM-8019
> URL: https://issues.apache.org/jira/browse/BEAM-8019
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chamikara Madhusanka Jayalath
> Assignee: Chamikara Madhusanka Jayalath
> Priority: Major
> Time Spent: 13h 20m
> Remaining Estimate: 0h
>
> This is to capture the Beam changes needed for this task.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
