[
https://issues.apache.org/jira/browse/BEAM-8019?focusedWorklogId=415232&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-415232
]
ASF GitHub Bot logged work on BEAM-8019:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Apr/20 00:53
Start Date: 03/Apr/20 00:53
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #11185: [BEAM-8019]
Updates Python SDK to handle remote SDK coders and preserve tags added by
remote SDKs and propagate restriction coders.
URL: https://github.com/apache/beam/pull/11185#discussion_r402676641
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -269,11 +277,9 @@ def visit_transform(self, transform_node):
pcoll.element_type, transform_node.full_label)
key_type, value_type = pcoll.element_type.tuple_types
if transform_node.outputs:
- from apache_beam.runners.portability.fn_api_runner.translations \
- import only_element
key = (
- None if None in transform_node.outputs.keys() else
only_element(
- transform_node.outputs.keys()))
+ None if None in transform_node.outputs.keys() else
+ DataflowRunner._only_element(transform_node.outputs.keys()))
Review comment:
The conditional is a tautology; just return
`_only_element(transform_node.outputs.keys())`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 415232)
Time Spent: 15h 20m (was: 15h 10m)
> Support cross-language transforms for DataflowRunner
> ----------------------------------------------------
>
> Key: BEAM-8019
> URL: https://issues.apache.org/jira/browse/BEAM-8019
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chamikara Madhusanka Jayalath
> Assignee: Chamikara Madhusanka Jayalath
> Priority: Major
> Time Spent: 15h 20m
> Remaining Estimate: 0h
>
> This is to capture the Beam changes needed for this task.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
