[
https://issues.apache.org/jira/browse/BEAM-9562?focusedWorklogId=414885&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-414885
]
ASF GitHub Bot logged work on BEAM-9562:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Apr/20 17:22
Start Date: 02/Apr/20 17:22
Worklog Time Spent: 10m
Work Description: boyuanzz commented on pull request #11199: [BEAM-9562]
Update Timer encoding with respect of dynamic timers
URL: https://github.com/apache/beam/pull/11199#discussion_r402481203
##########
File path:
model/fn-execution/src/main/resources/org/apache/beam/model/fnexecution/v1/standard_coders.yaml
##########
@@ -28,6 +28,23 @@
# one of a few standard JSON types such as numbers, strings, dicts
that map naturally
# to the type encoded by the coder.
#
+# Java code snippet to generate example bytes:
+# Coder<Timer<String>> coder = Timer.Coder.of(StringUtf8Coder.of(),
GlobalWindow.Coder.INSTANCE);
+# Instant now = new Instant(1000L);
+# Timer<String> timer = Timer.of(
+# "key",
+# "tag",
+# now,
+# now,
+# Collections.singletonList(GlobalWindow.INSTANCE),
+# PaneInfo.NO_FIRING);
+# byte[] byets = CoderUtils.encodeToByteArray(coder, timer);
+# String str = new String(byets,
java.nio.charset.StandardCharsets.ISO_8859_1);
Review comment:
Kind of sure since it works for me. And I found usage here:
https://github.com/apache/beam/blob/03c8544227530eb01dd0c64335e404ea387ee3a8/runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/CommonCoderTest.java#L190
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 414885)
Time Spent: 10h 10m (was: 10h)
> Remove timer from PCollection and treat timers as Elements
> -----------------------------------------------------------
>
> Key: BEAM-9562
> URL: https://issues.apache.org/jira/browse/BEAM-9562
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-harness
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 10h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
