[
https://issues.apache.org/jira/browse/BEAM-9562?focusedWorklogId=414945&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-414945
]
ASF GitHub Bot logged work on BEAM-9562:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Apr/20 18:02
Start Date: 02/Apr/20 18:02
Worklog Time Spent: 10m
Work Description: boyuanzz commented on pull request #11199: [BEAM-9562]
Update Timer encoding with respect of dynamic timers
URL: https://github.com/apache/beam/pull/11199#discussion_r402509304
##########
File path: sdks/python/apache_beam/coders/coders_test_common.py
##########
@@ -80,8 +81,9 @@ def tearDownClass(cls):
coders.RunnerAPICoderHolder,
coders.ToBytesCoder
])
- assert not standard - cls.seen, standard - cls.seen
- assert not standard - cls.seen_nested, standard - cls.seen_nested
+ cls.seen_nested -= set([coders.ProtoCoder, CustomCoder])
+ assert not standard - cls.seen
+ assert not cls.seen_nested - standard
Review comment:
The major change here is `assert not cls.seen_nested - standard`. In my
case I found that there is a `TimerCoder` in `standard` set, which is expected,
but not in `cls.seen_nested`. I checked the code
https://github.com/apache/beam/blob/b3e06126405105836f9ae15a15d5e1c7189b7f6e/sdks/python/apache_beam/coders/coders_test_common.py#L93,
only when the input coder is a `TupleCoder`, there are new coders added into
`cls.seen_nested`, which means, `cls.seen_nested` should be a subset of
`standard`, correct? @robertwb What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 414945)
Time Spent: 10h 40m (was: 10.5h)
> Remove timer from PCollection and treat timers as Elements
> -----------------------------------------------------------
>
> Key: BEAM-9562
> URL: https://issues.apache.org/jira/browse/BEAM-9562
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-harness
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 10h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
