[
https://issues.apache.org/jira/browse/BEAM-8019?focusedWorklogId=415224&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-415224
]
ASF GitHub Bot logged work on BEAM-8019:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Apr/20 00:53
Start Date: 03/Apr/20 00:53
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #11185: [BEAM-8019]
Updates Python SDK to handle remote SDK coders and preserve tags added by
remote SDKs and propagate restriction coders.
URL: https://github.com/apache/beam/pull/11185#discussion_r402672185
##########
File path: sdks/python/apache_beam/coders/coders.py
##########
@@ -1383,22 +1385,50 @@ def from_runner_api_parameter(payload, components,
context):
write_state_threshold=int(payload))
-class RunnerAPICoderHolder(Coder):
+class CoderElementType(typehints.TypeConstraint):
+ """An element type that just holds a coder proto."""
+ def __init__(self, coder_proto, context):
+ self.coder_proto = coder_proto
Review comment:
Logically the ElementType should hold the ExternalCoder, and the
ExternalCoder should hold the proto. (This will also help some issues where
coders are requested manually and then not respected.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 415224)
Time Spent: 14h 50m (was: 14h 40m)
> Support cross-language transforms for DataflowRunner
> ----------------------------------------------------
>
> Key: BEAM-8019
> URL: https://issues.apache.org/jira/browse/BEAM-8019
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chamikara Madhusanka Jayalath
> Assignee: Chamikara Madhusanka Jayalath
> Priority: Major
> Time Spent: 14h 50m
> Remaining Estimate: 0h
>
> This is to capture the Beam changes needed for this task.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
