[
https://issues.apache.org/jira/browse/BEAM-4374?focusedWorklogId=417118&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-417118
]
ASF GitHub Bot logged work on BEAM-4374:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Apr/20 21:02
Start Date: 06/Apr/20 21:02
Worklog Time Spent: 10m
Work Description: ajamato commented on pull request #11325: [BEAM-4374,
BEAM-6189] Delete and remove deprecated Metrics proto
URL: https://github.com/apache/beam/pull/11325#discussion_r404384314
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/control/BeamFnMapTaskExecutor.java
##########
@@ -341,30 +339,16 @@ void updateProgress() {
grpcWriteOperation.abortWait();
}
- // TODO(BEAM-6189): Replace getProcessBundleProgress with
getMonitoringInfos when Metrics
- // is deprecated.
ProcessBundleProgressResponse processBundleProgressResponse =
MoreFutures.get(bundleProcessOperation.getProcessBundleProgress());
final List<MonitoringInfo> monitoringInfosList =
processBundleProgressResponse.getMonitoringInfosList();
- // Supporting deprecated metrics until all supported runners are
migrated to using
- // MonitoringInfos
- Metrics metrics = processBundleProgressResponse.getMetrics();
- double elementsConsumed =
-
bundleProcessOperation.getInputElementsConsumed(monitoringInfosList);
-
- if (elementsConsumed == 0) {
- elementsConsumed =
bundleProcessOperation.getInputElementsConsumed(metrics);
- }
-
updateMetrics(monitoringInfosList);
- updateMetricsDeprecated(metrics);
Review comment:
Are you sure this won't break existing integrations? I believe only the
Python and Java SDK have moved everything to MonitoringInfos. The Go SDK has
not yet
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 417118)
Time Spent: 38.5h (was: 38h 20m)
> Update existing metrics in the FN API to use new Metric Schema
> --------------------------------------------------------------
>
> Key: BEAM-4374
> URL: https://issues.apache.org/jira/browse/BEAM-4374
> Project: Beam
> Issue Type: New Feature
> Components: beam-model
> Reporter: Alex Amato
> Priority: Major
> Time Spent: 38.5h
> Remaining Estimate: 0h
>
> Update existing metrics to use the new proto and cataloging schema defined in:
> [_https://s.apache.org/beam-fn-api-metrics_]
> * Check in new protos
> * Define catalog file for metrics
> * Port existing metrics to use this new format, based on catalog
> names+metadata
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
