[
https://issues.apache.org/jira/browse/BEAM-4374?focusedWorklogId=417126&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-417126
]
ASF GitHub Bot logged work on BEAM-4374:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Apr/20 21:09
Start Date: 06/Apr/20 21:09
Worklog Time Spent: 10m
Work Description: ajamato commented on pull request #11325: [BEAM-4374,
BEAM-6189] Delete and remove deprecated Metrics proto
URL: https://github.com/apache/beam/pull/11325#discussion_r404379886
##########
File path: model/fn-execution/src/main/proto/beam_fn_api.proto
##########
@@ -253,18 +253,13 @@ message ProcessBundleRequest {
}
message ProcessBundleResponse {
- // (Optional) If metrics reporting is supported by the SDK, this represents
- // the final metrics to record for this bundle.
- // DEPRECATED
- Metrics metrics = 1;
-
// (Optional) Specifies that the bundle has not been completed and the
// following applications need to be scheduled and executed in the future.
// A runner that does not yet support residual roots MUST still check that
// this is empty for correctness.
repeated DelayedBundleApplication residual_roots = 2;
- // (Required) The list of metrics or other MonitoredState
+ // DEPRECATED (Required) The list of metrics or other MonitoredState
// collected while processing this bundle.
repeated org.apache.beam.model.pipeline.v1.MonitoringInfo monitoring_infos =
3;
Review comment:
Why are these also deprecated now?
Will you be only using the bytes map now? I don't really get how this will
work by looking at the ProcessBundle(Progress)Response protos. It seems like
you would need the MonitoringInfo at least once to have enough metadata be able
to decode the bytes and associate multiple updates together. I don't really
understand the protocol that you have in mind here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 417126)
Time Spent: 39.5h (was: 39h 20m)
> Update existing metrics in the FN API to use new Metric Schema
> --------------------------------------------------------------
>
> Key: BEAM-4374
> URL: https://issues.apache.org/jira/browse/BEAM-4374
> Project: Beam
> Issue Type: New Feature
> Components: beam-model
> Reporter: Alex Amato
> Priority: Major
> Time Spent: 39.5h
> Remaining Estimate: 0h
>
> Update existing metrics to use the new proto and cataloging schema defined in:
> [_https://s.apache.org/beam-fn-api-metrics_]
> * Check in new protos
> * Define catalog file for metrics
> * Port existing metrics to use this new format, based on catalog
> names+metadata
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
