[
https://issues.apache.org/jira/browse/BEAM-9731?focusedWorklogId=419138&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-419138
]
ASF GitHub Bot logged work on BEAM-9731:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Apr/20 05:55
Start Date: 09/Apr/20 05:55
Worklog Time Spent: 10m
Work Description: thetorpedodog commented on issue #11359: [BEAM-9731]
Include more detail in passert.Equals errors.
URL: https://github.com/apache/beam/pull/11359#issuecomment-611343232
R: @lostluck
Some notes:
I chose a somewhat gawdy format for this just to make it very highly visible
and easy-to-read on the terminal. I find it works pretty well, but I'm open to
suggestions. Here's the output from one of the test cases:
```
actual PCollection does not match expected values
=========
2 correct entries (present in both)
=========
1 unexpected entries (present in actual, missing in expected)
+++
too many
=========
1 missing entries (missing in actual, present in expected)
---
not enough
```
The checklist suggests updating `CHANGES.md`. This seems a bit small for
that.
This is covered by the Google CLA.
Thanks for the review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 419138)
Time Spent: 20m (was: 10m)
> golang passert.Equals output is unhelpful
> -----------------------------------------
>
> Key: BEAM-9731
> URL: https://issues.apache.org/jira/browse/BEAM-9731
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go, testing
> Reporter: Paul Fisher
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The output from using passert.Equals includes only one of the missing or
> unexpected elements from the diff. Including all of the missing and
> unexpected elements will make tests much easier to debug.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)