[
https://issues.apache.org/jira/browse/BEAM-9731?focusedWorklogId=419140&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-419140
]
ASF GitHub Bot logged work on BEAM-9731:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Apr/20 05:57
Start Date: 09/Apr/20 05:57
Worklog Time Spent: 10m
Work Description: thetorpedodog commented on pull request #11359:
[BEAM-9731] Include more detail in passert.Equals errors.
URL: https://github.com/apache/beam/pull/11359#discussion_r405972252
##########
File path: sdks/go/pkg/beam/testing/passert/passert.go
##########
@@ -32,29 +32,6 @@ import (
//go:generate starcgen --package=passert
--identifiers=diffFn,failFn,failKVFn,failGBKFn,hashFn,sumFn
Review comment:
do i need to add something here (or add a similar stanza to the new
equals.go file)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 419140)
Time Spent: 0.5h (was: 20m)
> golang passert.Equals output is unhelpful
> -----------------------------------------
>
> Key: BEAM-9731
> URL: https://issues.apache.org/jira/browse/BEAM-9731
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go, testing
> Reporter: Paul Fisher
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The output from using passert.Equals includes only one of the missing or
> unexpected elements from the diff. Including all of the missing and
> unexpected elements will make tests much easier to debug.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
