[
https://issues.apache.org/jira/browse/BEAM-8872?focusedWorklogId=423700&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-423700
]
ASF GitHub Bot logged work on BEAM-8872:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Apr/20 20:12
Start Date: 16/Apr/20 20:12
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #11418: [BEAM-8872]
Support split at fraction for OffsetRangeTracker
URL: https://github.com/apache/beam/pull/11418#discussion_r409820103
##########
File path:
runners/core-java/src/main/java/org/apache/beam/runners/core/SplittableProcessElementInvoker.java
##########
@@ -51,11 +51,6 @@ public Result(
@Nullable WatermarkEstimatorStateT futureWatermarkEstimatorState) {
checkArgument(continuation != null, "continuation must not be null");
this.continuation = continuation;
- if (continuation.shouldResume()) {
- checkArgument(
- residualRestriction != null,
- "residual restriction must not be null if continuation indicate it
should resume");
- }
this.residualRestriction = residualRestriction;
this.futureOutputWatermark = futureOutputWatermark;
this.futureWatermarkEstimatorState = futureWatermarkEstimatorState;
Review comment:
I believe the comment below could be incorrect. If we get stop(), we
shouldn't have a residual restriction.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 423700)
Time Spent: 2h 10m (was: 2h)
> Add support for splitting at fractions > 0 to
> org.apache.beam.sdk.transforms.splittabledofn.OffsetRangeTracker
> --------------------------------------------------------------------------------------------------------------
>
> Key: BEAM-8872
> URL: https://issues.apache.org/jira/browse/BEAM-8872
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Luke Cwik
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> org.apache.beam.sdk.transforms.splittabledofn.OffsetRangeTracker only
> supports checkpointing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
