[
https://issues.apache.org/jira/browse/BEAM-8872?focusedWorklogId=423696&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-423696
]
ASF GitHub Bot logged work on BEAM-8872:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Apr/20 20:11
Start Date: 16/Apr/20 20:11
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #11418: [BEAM-8872]
Support split at fraction for OffsetRangeTracker
URL: https://github.com/apache/beam/pull/11418#discussion_r409806021
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/splittabledofn/OffsetRangeTrackerTest.java
##########
@@ -47,16 +48,9 @@ public void testTryClaim() throws Exception {
@Test
public void testCheckpointUnstarted() throws Exception {
OffsetRangeTracker tracker = new OffsetRangeTracker(new OffsetRange(100,
200));
- expected.expect(IllegalStateException.class);
- tracker.trySplit(0).getResidual();
- }
-
- @Test
- public void testCheckpointOnlyFailedClaim() throws Exception {
- OffsetRangeTracker tracker = new OffsetRangeTracker(new OffsetRange(100,
200));
- assertFalse(tracker.tryClaim(250L));
- expected.expect(IllegalStateException.class);
- OffsetRange checkpoint = tracker.trySplit(0).getResidual();
+ SplitResult res = tracker.trySplit(0);
+ assertEquals(new OffsetRange(100, 100), res.getPrimary());
+ assertEquals(new OffsetRange(100, 200), res.getResidual());
Review comment:
primary and residual shouldn't have the same value, primary should be an
empty range like `[100, 100)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 423696)
Time Spent: 1h 40m (was: 1.5h)
> Add support for splitting at fractions > 0 to
> org.apache.beam.sdk.transforms.splittabledofn.OffsetRangeTracker
> --------------------------------------------------------------------------------------------------------------
>
> Key: BEAM-8872
> URL: https://issues.apache.org/jira/browse/BEAM-8872
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Luke Cwik
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> org.apache.beam.sdk.transforms.splittabledofn.OffsetRangeTracker only
> supports checkpointing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
