[
https://issues.apache.org/jira/browse/BEAM-1819?focusedWorklogId=424158&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-424158
]
ASF GitHub Bot logged work on BEAM-1819:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/20 12:49
Start Date: 17/Apr/20 12:49
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #11154: [BEAM-1819] Key
should be available in @OnTimer methods
URL: https://github.com/apache/beam/pull/11154#discussion_r410196509
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -837,11 +837,15 @@ public void onProcessingTime(InternalTimer<ByteBuffer,
TimerData> timer) {
// allow overriding this in ExecutableStageDoFnOperator to set the key
context
protected void fireTimerInternal(Object key, TimerData timerData) {
- fireTimer(timerData);
+ if (key instanceof java.nio.ByteBuffer) {
+ key = FlinkKeyUtils.decodeKey((ByteBuffer) key, keyCoder);
Review comment:
The key is always stored as ByteBuffer. This is also reflected in the method
calls to this method. Please change the signature of the method to be
```
void fireTimerInternal(ByteBuffer key, TimerData timerdata)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 424158)
> Key should be available in @OnTimer methods
> -------------------------------------------
>
> Key: BEAM-1819
> URL: https://issues.apache.org/jira/browse/BEAM-1819
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Thomas Groh
> Assignee: Shehzaad Nakhoda
> Priority: Major
> Time Spent: 26h
> Remaining Estimate: 0h
>
> Every timer firing has an associated key. This key should be available when
> the timer is delivered to a user's {{DoFn}}, so they don't have to store it
> in state.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
