[
https://issues.apache.org/jira/browse/BEAM-1819?focusedWorklogId=425291&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-425291
]
ASF GitHub Bot logged work on BEAM-1819:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/20 11:47
Start Date: 20/Apr/20 11:47
Worklog Time Spent: 10m
Work Description: mxm commented on a change in pull request #11154:
URL: https://github.com/apache/beam/pull/11154#discussion_r411312886
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -837,11 +837,15 @@ public void onProcessingTime(InternalTimer<ByteBuffer,
TimerData> timer) {
// allow overriding this in ExecutableStageDoFnOperator to set the key
context
protected void fireTimerInternal(Object key, TimerData timerData) {
- fireTimer(timerData);
+ if (key instanceof java.nio.ByteBuffer) {
+ key = FlinkKeyUtils.decodeKey((ByteBuffer) key, keyCoder);
Review comment:
The key is always encoded at this point. The issue is that some unit
tests use a non-encoded key which is incorrect. We have to fix this to change
the method signature to `ByteBuffer` here. As a workaround you could use
`keyedStateInternals.getCurrentKey()` which will return a decoded version of
the key.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 425291)
Time Spent: 26h 50m (was: 26h 40m)
> Key should be available in @OnTimer methods
> -------------------------------------------
>
> Key: BEAM-1819
> URL: https://issues.apache.org/jira/browse/BEAM-1819
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Thomas Groh
> Assignee: Shehzaad Nakhoda
> Priority: Major
> Time Spent: 26h 50m
> Remaining Estimate: 0h
>
> Every timer firing has an associated key. This key should be available when
> the timer is delivered to a user's {{DoFn}}, so they don't have to store it
> in state.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
