[
https://issues.apache.org/jira/browse/BEAM-8871?focusedWorklogId=424442&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-424442
]
ASF GitHub Bot logged work on BEAM-8871:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/20 21:34
Start Date: 17/Apr/20 21:34
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #11454: [BEAM-8871]
Support trySplit for ByteKeyRangeTracker
URL: https://github.com/apache/beam/pull/11454#discussion_r410480834
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/io/range/ByteKeyRange.java
##########
@@ -218,6 +218,10 @@ public double estimateFractionForKey(ByteKey key) {
public ByteKey interpolateKey(double fraction) {
checkArgument(
fraction >= 0.0 && fraction < 1.0, "Fraction %s must be in the range
[0, 1)", fraction);
+ // Return starKey when fraction is 0 in order to avoid adding trailing
zeros during computation.
Review comment:
s/starKey/startKey
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 424442)
Time Spent: 40m (was: 0.5h)
> Add support for splitting at fractions > 0 to
> org.apache.beam.sdk.transforms.splittabledofn.ByteKeyRangeTracker
> ---------------------------------------------------------------------------------------------------------------
>
> Key: BEAM-8871
> URL: https://issues.apache.org/jira/browse/BEAM-8871
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Luke Cwik
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> org.apache.beam.sdk.transforms.splittabledofn.ByteKeyRangeTracker only
> supports checkpointing
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
