[
https://issues.apache.org/jira/browse/BEAM-8871?focusedWorklogId=424737&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-424737
]
ASF GitHub Bot logged work on BEAM-8871:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Apr/20 03:42
Start Date: 18/Apr/20 03:42
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #11454: [BEAM-8871]
Support trySplit for ByteKeyRangeTracker
URL: https://github.com/apache/beam/pull/11454#discussion_r410594056
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/splittabledofn/ByteKeyRangeTrackerTest.java
##########
@@ -287,4 +318,30 @@ public void testBacklogPartiallyCompleted() {
tracker.tryClaim(ByteKey.of(0xa0));
assertThat(tracker.getSize(), allOf(greaterThan(0.), lessThan(1.)));
}
+
+ /** Asserts the two ByteKey are equal except trailing zeros. */
+ private static void assertByteKeyEqualExceptPadding(ByteKey expected,
ByteKey key) {
Review comment:
Make that method public and call it from this test since they are both in
the same module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 424737)
Time Spent: 1h 20m (was: 1h 10m)
> Add support for splitting at fractions > 0 to
> org.apache.beam.sdk.transforms.splittabledofn.ByteKeyRangeTracker
> ---------------------------------------------------------------------------------------------------------------
>
> Key: BEAM-8871
> URL: https://issues.apache.org/jira/browse/BEAM-8871
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Luke Cwik
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> org.apache.beam.sdk.transforms.splittabledofn.ByteKeyRangeTracker only
> supports checkpointing
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
