[ 
https://issues.apache.org/jira/browse/BEAM-9787?focusedWorklogId=425438&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-425438
 ]

ASF GitHub Bot logged work on BEAM-9787:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Apr/20 19:48
            Start Date: 20/Apr/20 19:48
    Worklog Time Spent: 10m 
      Work Description: ananvay commented on a change in pull request #11466:
URL: https://github.com/apache/beam/pull/11466#discussion_r411645755



##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -1182,6 +1188,11 @@ def run_Read(self, transform_node, options):
         raise ValueError(
             'BigQuery source is not currently available for use '
             'in streaming pipelines.')
+      debug_options = options.view_as(DebugOptions)
+      use_fn_api = (debug_options.experiments and
+                    'beam_fn_api' in debug_options.experiments)
+      if use_fn_api:

Review comment:
       In general, yes, but the only support way of batch fnapi is with UW -- 
they shouldn't be trying fnapi batch jobs without it. That said, perhaps it 
makes sense to check both separately (just to ensure that the --use_runner_v2 
also independently triggers this check, just in case someone in the future 
decides to accidentally modify something)?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 425438)
    Time Spent: 1.5h  (was: 1h 20m)

> Send clear error to users trying to use BigQuerySource on FnApi pipelines on 
> Python SDK
> ---------------------------------------------------------------------------------------
>
>                 Key: BEAM-9787
>                 URL: https://issues.apache.org/jira/browse/BEAM-9787
>             Project: Beam
>          Issue Type: Bug
>          Components: io-py-gcp
>            Reporter: Pablo Estrada
>            Assignee: Pablo Estrada
>            Priority: Major
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to