[
https://issues.apache.org/jira/browse/BEAM-9787?focusedWorklogId=425444&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-425444
]
ASF GitHub Bot logged work on BEAM-9787:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/20 19:52
Start Date: 20/Apr/20 19:52
Worklog Time Spent: 10m
Work Description: pabloem removed a comment on issue #11466:
URL: https://github.com/apache/beam/pull/11466#issuecomment-616772850
The unit test checks both of them separately, so if either of them changes,
the unit test will fail. WDYT about that?
On Mon, Apr 20, 2020 at 12:48 PM ananvay <[email protected]> wrote:
> *@ananvay* commented on this pull request.
> ------------------------------
>
> In sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
> <https://github.com/apache/beam/pull/11466#discussion_r411645755>:
>
> > @@ -1182,6 +1188,11 @@ def run_Read(self, transform_node, options):
> raise ValueError(
> 'BigQuery source is not currently available for use '
> 'in streaming pipelines.')
> + debug_options = options.view_as(DebugOptions)
> + use_fn_api = (debug_options.experiments and
> + 'beam_fn_api' in debug_options.experiments)
> + if use_fn_api:
>
> In general, yes, but the only support way of batch fnapi is with UW --
> they shouldn't be trying fnapi batch jobs without it. That said, perhaps it
> makes sense to check both separately (just to ensure that the
> --use_runner_v2 also independently triggers this check, just in case
> someone in the future decides to accidentally modify something)?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/11466#discussion_r411645755>, or
> unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AAJ5Z3FWYMA4C2G6THQAZPDRNSRJDANCNFSM4MMV2ZOA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 425444)
Time Spent: 2h (was: 1h 50m)
> Send clear error to users trying to use BigQuerySource on FnApi pipelines on
> Python SDK
> ---------------------------------------------------------------------------------------
>
> Key: BEAM-9787
> URL: https://issues.apache.org/jira/browse/BEAM-9787
> Project: Beam
> Issue Type: Bug
> Components: io-py-gcp
> Reporter: Pablo Estrada
> Assignee: Pablo Estrada
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
