[
https://issues.apache.org/jira/browse/BEAM-9887?focusedWorklogId=430848&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-430848
]
ASF GitHub Bot logged work on BEAM-9887:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/May/20 18:57
Start Date: 05/May/20 18:57
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on pull request #11609:
URL: https://github.com/apache/beam/pull/11609#issuecomment-624243528
> Will this line ever get hit?
We always convert logical types to their base type when serializing with
SchemaCoder, and convert back to the input type when deserializing. Other than
that I think the only time it should get called is when constructing a Row
instance (unless you use attachValues).
> Can we consider that the input value provided is of BaseType, which we can
convert to InputType and store in memory?
Would this just be so that we're guaranteed to call `toInputType` whenever
setting a value on Row? This PR accomplishes the same thing right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 430848)
Time Spent: 2h (was: 1h 50m)
> Throw IllegalArgumentException when building Row with logical types with
> Invalid input
> ---------------------------------------------------------------------------------------
>
> Key: BEAM-9887
> URL: https://issues.apache.org/jira/browse/BEAM-9887
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Rahul Patwari
> Assignee: Rahul Patwari
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> schema.logicaltypes.FixedBytes logical type expects an argument - the length
> of the byte[].
> When an invalid input value (with length < expectedLength) is provided while
> building the Row with FixedBytes logical type, IllegalArgumentException is
> expected. But, the Exception is not thrown. The below code illustrates the
> behaviour:
> {code:java}
> Schema schema = Schema.builder().addLogicalTypeField("char",
> FixedBytes.of(10)).build();
> byte[] byteArray = {1, 2, 3, 4, 5};
> Row row = Row.withSchema(schema).withFieldValue("char", byteArray).build();
> System.out.println(Arrays.toString(row.getLogicalTypeValue("char",
> byte[].class)));
> {code}
> The above code prints "[1, 2, 3, 4, 5]" with length 5 to the console, whereas
> the expected length of FixedBytes, is 10.
> The code is run on the master branch.
> The behaviour is as expected with 2.20.0 release.
> {{ }}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
