[
https://issues.apache.org/jira/browse/BEAM-9887?focusedWorklogId=431334&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-431334
]
ASF GitHub Bot logged work on BEAM-9887:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/May/20 17:44
Start Date: 06/May/20 17:44
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on pull request #11609:
URL: https://github.com/apache/beam/pull/11609#issuecomment-624792506
> In that case, there is no need to handle this else case right? as we are
making sure that the input has expected length while building the Row.
`checkArgument` ensures that the condition is true, so we are rejecting byte
arrays that are too short, and accepting anything longer than the fixed size. I
don't think there's any capability that pads zeroes for short arrays, this
logic just allows _longer_ byte arrays, and copies out the appropriate portion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 431334)
Time Spent: 2h 50m (was: 2h 40m)
> Throw IllegalArgumentException when building Row with logical types with
> Invalid input
> ---------------------------------------------------------------------------------------
>
> Key: BEAM-9887
> URL: https://issues.apache.org/jira/browse/BEAM-9887
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Rahul Patwari
> Assignee: Rahul Patwari
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> schema.logicaltypes.FixedBytes logical type expects an argument - the length
> of the byte[].
> When an invalid input value (with length < expectedLength) is provided while
> building the Row with FixedBytes logical type, IllegalArgumentException is
> expected. But, the Exception is not thrown. The below code illustrates the
> behaviour:
> {code:java}
> Schema schema = Schema.builder().addLogicalTypeField("char",
> FixedBytes.of(10)).build();
> byte[] byteArray = {1, 2, 3, 4, 5};
> Row row = Row.withSchema(schema).withFieldValue("char", byteArray).build();
> System.out.println(Arrays.toString(row.getLogicalTypeValue("char",
> byte[].class)));
> {code}
> The above code prints "[1, 2, 3, 4, 5]" with length 5 to the console, whereas
> the expected length of FixedBytes, is 10.
> The code is run on the master branch.
> The behaviour is as expected with 2.20.0 release.
> {{ }}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
