[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=431891&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-431891
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/May/20 20:59
Start Date: 07/May/20 20:59
Worklog Time Spent: 10m
Work Description: chadrik commented on a change in pull request #11632:
URL: https://github.com/apache/beam/pull/11632#discussion_r421790116
##########
File path: sdks/python/apache_beam/dataframe/convert.py
##########
@@ -16,13 +16,23 @@
from __future__ import absolute_import
+import typing
+
import inspect
from apache_beam import pvalue
from apache_beam.dataframe import expressions
from apache_beam.dataframe import frame_base
from apache_beam.dataframe import transforms
+if typing.TYPE_CHECKING:
+ # pylint: disable=ungrouped-imports
+ from typing import Any
+ from typing import Dict
+ from typing import Tuple
+ from typing import Union
Review comment:
I should mention that a solution to the first issue is that we can refer
to these types as strings, such as `'Any'`, but that's certainly a lot more
awkward, and developers are likely to forget to do so and get
confused/frustrated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 431891)
Time Spent: 81h 10m (was: 81h)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 81h 10m
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
