[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=431942&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-431942
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/May/20 01:03
Start Date: 08/May/20 01:03
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #11632:
URL: https://github.com/apache/beam/pull/11632#discussion_r421878491
##########
File path: sdks/python/apache_beam/dataframe/transforms.py
##########
@@ -248,7 +261,12 @@ def _dict_union(dicts):
return result
-def _flatten(valueish, root=()):
+def _flatten(
+ valueish, # type: Union[T, Tuple[T, ...], Dict[Any, T]]
Review comment:
Generally I'd agree that `Iterable`/`Mapping` would be preferable, but
here I want to be restrictive about the kinds of values I decompose.
The keys types of the mapping would be `Union[None, int, U]`, so you'd have
to cast anyway, so I think it's simpler to leave as is.
Still, good food for thought.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 431942)
Time Spent: 81h 50m (was: 81h 40m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 81h 50m
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
