[
https://issues.apache.org/jira/browse/BEAM-8132?focusedWorklogId=432133&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-432133
]
ASF GitHub Bot logged work on BEAM-8132:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/May/20 14:15
Start Date: 08/May/20 14:15
Worklog Time Spent: 10m
Work Description: kamilwu commented on a change in pull request #11567:
URL: https://github.com/apache/beam/pull/11567#discussion_r422167855
##########
File path: sdks/python/apache_beam/testing/load_tests/load_test.py
##########
@@ -67,22 +82,30 @@ def _str_to_boolean(value):
class LoadTest(object):
+ """Base class for all integration and performance tests which export
+ metrics to external databases: BigQuery or/and InfluxDB.
+
+ Refer to :class:`~apache_beam.testing.load_tests.LoadTestOptions` for more
+ information on the required pipeline options.
+
+ If using InfluxDB with Basic HTTP authentication enabled, provide the
+ following environment options: `INFLUXDB_USER` and `INFLUXDB_USER_PASSWORD`.
+ """
def __init__(self):
# Be sure to set blocking to false for timeout_ms to work properly
self.pipeline = TestPipeline(is_integration_test=True, blocking=False)
assert not self.pipeline.blocking
- load_test_options = self.pipeline.get_pipeline_options().view_as(
- LoadTestOptions)
- self.timeout_ms = load_test_options.timeout_ms
- self.input_options = load_test_options.input_options
- self.metrics_namespace = load_test_options.metrics_table or 'default'
- publish_to_bq = load_test_options.publish_to_big_query
+ options = self.pipeline.get_pipeline_options().view_as(LoadTestOptions)
+ self.timeout_ms = options.timeout_ms
+ self.input_options = options.input_options
+ self.metrics_namespace = options.metrics_table or 'default'
+ publish_to_bq = options.publish_to_big_query
if publish_to_bq is None:
Review comment:
Our goal is to keep sending metrics to BigQuery for some time. think
it'd good to keep the interface intact until we eventually abandon bq.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 432133)
Time Spent: 5h 10m (was: 5h)
> Create metrics publisher in Python SDK
> --------------------------------------
>
> Key: BEAM-8132
> URL: https://issues.apache.org/jira/browse/BEAM-8132
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Kamil Wasilewski
> Assignee: Kamil Wasilewski
> Priority: Major
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
