[
https://issues.apache.org/jira/browse/BEAM-10065?focusedWorklogId=437295&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-437295
]
ASF GitHub Bot logged work on BEAM-10065:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/May/20 03:29
Start Date: 27/May/20 03:29
Worklog Time Spent: 10m
Work Description: epicfaace commented on a change in pull request #11797:
URL: https://github.com/apache/beam/pull/11797#discussion_r430491681
##########
File path: website/www/site/static/js/language-switch.js
##########
@@ -113,7 +113,7 @@ $(document).ready(function() {
}
// Swapping visibility of code blocks.
- $(this.selector).hide();
+ $(this.selector).not(".language-md").hide();
Review comment:
```suggestion
$(this.selector).hide();
```
##########
File path: website/www/site/static/js/language-switch.js
##########
@@ -113,7 +113,7 @@ $(document).ready(function() {
}
// Swapping visibility of code blocks.
- $(this.selector).hide();
+ $(this.selector).not(".language-md").hide();
Review comment:
Accidentally added that change in -- removing it now
##########
File path: website/www/site/static/js/language-switch.js
##########
@@ -113,7 +113,7 @@ $(document).ready(function() {
}
// Swapping visibility of code blocks.
- $(this.selector).hide();
+ $(this.selector).not(".language-md").hide();
Review comment:
Otherwise, the template (which is in ` ```md`) becomes automatically
hidden by this script. We can either add this change in, or we can disable
syntax highlighting in the template by replacing ` ```md` with ` ``` `.
##########
File path: website/www/site/static/js/language-switch.js
##########
@@ -113,7 +113,7 @@ $(document).ready(function() {
}
// Swapping visibility of code blocks.
- $(this.selector).hide();
+ $(this.selector).not(".language-md").hide();
Review comment:
I don't think we'll ever have a language switcher with ` ```md ` code
blocks, so this change should be safe to add.
##########
File path: website/www/site/static/js/language-switch.js
##########
@@ -113,7 +113,7 @@ $(document).ready(function() {
}
// Swapping visibility of code blocks.
- $(this.selector).hide();
+ $(this.selector).not(".language-md").hide();
Review comment:
```suggestion
$(this.selector).hide();
```
##########
File path: website/www/site/content/en/contribute/release-guide.md
##########
@@ -711,54 +711,54 @@ all major features and bug fixes, and all known issues.
Template:
-```
- We are happy to present the new {$RELEASE_VERSION} release of Beam. This
release includes both improvements and new functionality.
- See the [download page](/get-started/downloads/{$DOWNLOAD_ANCHOR}) for
this release.<!--more-->
- For more information on changes in {$RELEASE_VERSION}, check out the
- [detailed release notes]({$JIRA_RELEASE_NOTES}).
+```md
Review comment:
```suggestion
```
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 437295)
Time Spent: 0.5h (was: 20m)
> Docs - Beam "Release guide" template is broken
> ----------------------------------------------
>
> Key: BEAM-10065
> URL: https://issues.apache.org/jira/browse/BEAM-10065
> Project: Beam
> Issue Type: Bug
> Components: website
> Reporter: Ashwin Ramaswami
> Assignee: Ashwin Ramaswami
> Priority: P2
> Attachments: Screen Shot 2020-05-22 at 9.09.35 AM.png
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> It just shows "e>" for the template.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
