[ 
https://issues.apache.org/jira/browse/BEAM-10065?focusedWorklogId=437506&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-437506
 ]

ASF GitHub Bot logged work on BEAM-10065:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/May/20 03:58
            Start Date: 27/May/20 03:58
    Worklog Time Spent: 10m 
      Work Description: ibzib commented on a change in pull request #11797:
URL: https://github.com/apache/beam/pull/11797#discussion_r430480420



##########
File path: website/www/site/static/js/language-switch.js
##########
@@ -113,7 +113,7 @@ $(document).ready(function() {
                }
 
                 // Swapping visibility of code blocks.
-                $(this.selector).hide();
+                $(this.selector).not(".language-md").hide();

Review comment:
       Why is this change needed?

##########
File path: website/www/site/static/js/language-switch.js
##########
@@ -113,7 +113,7 @@ $(document).ready(function() {
                }
 
                 // Swapping visibility of code blocks.
-                $(this.selector).hide();
+                $(this.selector).not(".language-md").hide();

Review comment:
       This is a bigger problem than just markdown. Every code block that 
specifies a language that is not toggled on will be hidden. I filed BEAM-10092.
   
   For now, since syntax highlighting is not important here, please remove the 
`md` and we can merge the rest of your changes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 437506)
    Time Spent: 40m  (was: 0.5h)

> Docs - Beam "Release guide" template is broken
> ----------------------------------------------
>
>                 Key: BEAM-10065
>                 URL: https://issues.apache.org/jira/browse/BEAM-10065
>             Project: Beam
>          Issue Type: Bug
>          Components: website
>            Reporter: Ashwin Ramaswami
>            Assignee: Ashwin Ramaswami
>            Priority: P2
>         Attachments: Screen Shot 2020-05-22 at 9.09.35 AM.png
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> It just shows "e>" for the template.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to