[
https://issues.apache.org/jira/browse/BEAM-10204?focusedWorklogId=441941&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441941
]
ASF GitHub Bot logged work on BEAM-10204:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jun/20 17:47
Start Date: 05/Jun/20 17:47
Worklog Time Spent: 10m
Work Description: tysonjh commented on a change in pull request #11933:
URL: https://github.com/apache/beam/pull/11933#discussion_r436071355
##########
File path:
sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLDialectSpecTest.java
##########
@@ -837,7 +834,6 @@ public void testLikeAllowsEscapingBackslash() {
}
@Test
- @Ignore("Currently non UTF-8 values are coerced to UTF-8")
public void testThrowsErrorForNonUTF8() {
Review comment:
This test name doesn't seem correct after these changes. What is it
testing now? What about the previous assertions on throwing an exception for
invalid utf8?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 441941)
Time Spent: 0.5h (was: 20m)
> @Ignore: re-enable LIKE operator related unit tests
> ---------------------------------------------------
>
> Key: BEAM-10204
> URL: https://issues.apache.org/jira/browse/BEAM-10204
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql-zetasql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: P2
> Labels: beam-fixit
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The following @Ignore tests can be enabled:
> ZetaSQLDialectSpecTest.testLike1
> ZetaSQLDialectSpecTest.testLikeAllowsEscapingNonSpecialCharacter
> ZetaSQLDialectSpecTest.testLikeAllowsEscapingBackslash
> ZetaSQLDialectSpecTest.testThrowsErrorForNonUTF8
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
