[
https://issues.apache.org/jira/browse/BEAM-10204?focusedWorklogId=441976&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441976
]
ASF GitHub Bot logged work on BEAM-10204:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jun/20 18:37
Start Date: 05/Jun/20 18:37
Worklog Time Spent: 10m
Work Description: amaliujia commented on a change in pull request #11933:
URL: https://github.com/apache/beam/pull/11933#discussion_r436094165
##########
File path:
sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLDialectSpecTest.java
##########
@@ -837,7 +834,6 @@ public void testLikeAllowsEscapingBackslash() {
}
@Test
- @Ignore("Currently non UTF-8 values are coerced to UTF-8")
public void testThrowsErrorForNonUTF8() {
Review comment:
This is a good point. I will choose to remove this test. I tried to dig
into ZetaSQL's documentation and internal tests suite, there was no clear
explanation how to deal with nonUTF8 chars by LIKE operator (there are
code-generated nonUTF8 test cases, but they don't have clear comments to
demonstrate their purpose)
So I will leave this part to be tested by internal test suite.
##########
File path:
sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLDialectSpecTest.java
##########
@@ -837,7 +834,6 @@ public void testLikeAllowsEscapingBackslash() {
}
@Test
- @Ignore("Currently non UTF-8 values are coerced to UTF-8")
public void testThrowsErrorForNonUTF8() {
Review comment:
This is a good point. I will choose to remove this test. I tried to dig
into ZetaSQL's documentation and internal tests suite, there was no clear
explanation how to deal with nonUTF8 chars by LIKE operator (there are
code-generated nonUTF8 test cases, but they don't have clear comments to
demonstrate their purpose).
So I will leave this part to be tested by internal test suite.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 441976)
Time Spent: 50m (was: 40m)
> @Ignore: re-enable LIKE operator related unit tests
> ---------------------------------------------------
>
> Key: BEAM-10204
> URL: https://issues.apache.org/jira/browse/BEAM-10204
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql-zetasql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: P2
> Labels: beam-fixit
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The following @Ignore tests can be enabled:
> ZetaSQLDialectSpecTest.testLike1
> ZetaSQLDialectSpecTest.testLikeAllowsEscapingNonSpecialCharacter
> ZetaSQLDialectSpecTest.testLikeAllowsEscapingBackslash
> ZetaSQLDialectSpecTest.testThrowsErrorForNonUTF8
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
