[
https://issues.apache.org/jira/browse/BEAM-10197?focusedWorklogId=442065&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442065
]
ASF GitHub Bot logged work on BEAM-10197:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jun/20 23:01
Start Date: 05/Jun/20 23:01
Worklog Time Spent: 10m
Work Description: udim commented on a change in pull request #11939:
URL: https://github.com/apache/beam/pull/11939#discussion_r436187871
##########
File path: sdks/python/apache_beam/typehints/typehints_test.py
##########
@@ -612,54 +613,70 @@ def test_match_type_variables(self):
hint.match_type_variables(typehints.Dict[int, str]))
-class SetHintTestCase(TypeHintTestCase):
+class BaseSetHintTest:
+ def __init__(self, string_type, py_type, beam_type, *args, **kwargs):
Review comment:
You should omit `*args, **kwargs` if there aren't any more args allowed.
This is the style we follow in this codebase. Here and below as well.
For example: if some code called `BaseSetHintTest('Set', set, typehints.Set,
typehints.FrozenSet)` would you rather it be silently ignored or raised as an
incorrect number of arguments?
##########
File path: sdks/python/apache_beam/typehints/typehints_test.py
##########
@@ -612,54 +613,70 @@ def test_match_type_variables(self):
hint.match_type_variables(typehints.Dict[int, str]))
-class SetHintTestCase(TypeHintTestCase):
+class BaseSetHintTest:
Review comment:
If `BaseSetHintTest` inherited from `TypeHintTestCase` you could avoid
multiple inheritance in the sub-classes below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 442065)
Time Spent: 50m (was: 40m)
> Support type hints for frozenset
> ---------------------------------
>
> Key: BEAM-10197
> URL: https://issues.apache.org/jira/browse/BEAM-10197
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Saavan Nanavati
> Priority: P2
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Beam's internal typing system currently supports type hints for set but not
> frozenset.
>
> This Jira ticket will add type annotation support for both frozenset and
> typing.FrozenSet.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
