[
https://issues.apache.org/jira/browse/BEAM-10197?focusedWorklogId=442547&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442547
]
ASF GitHub Bot logged work on BEAM-10197:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jun/20 00:35
Start Date: 08/Jun/20 00:35
Worklog Time Spent: 10m
Work Description: saavan-google-intern commented on a change in pull
request #11939:
URL: https://github.com/apache/beam/pull/11939#discussion_r436415339
##########
File path: sdks/python/apache_beam/typehints/typehints_test.py
##########
@@ -612,54 +613,70 @@ def test_match_type_variables(self):
hint.match_type_variables(typehints.Dict[int, str]))
-class SetHintTestCase(TypeHintTestCase):
+class BaseSetHintTest:
Review comment:
Just pushed a fix - BaseSetHintTest is now a wrapper for a nested class
that inherits from TypeHintTestCase (which inherits from TestCase), thereby
removing the multiple inheritance.
I think BaseSetHintTest can't directly inherit from TypeHintTestCase because
that would cause the unittest library to accidentally run the BaseSetHintTest
tests which cannot be run without first being instantiated by the child classes
(SetHintTestCase, FrozenSetHintTestCase). The nested class solves this issue -
see [here](https://stackoverflow.com/a/25695512).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 442547)
Time Spent: 2h (was: 1h 50m)
> Support type hints for frozenset
> ---------------------------------
>
> Key: BEAM-10197
> URL: https://issues.apache.org/jira/browse/BEAM-10197
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Saavan Nanavati
> Priority: P2
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Beam's internal typing system currently supports type hints for set but not
> frozenset.
>
> This Jira ticket will add type annotation support for both frozenset and
> typing.FrozenSet.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
