[
https://issues.apache.org/jira/browse/BEAM-10197?focusedWorklogId=442990&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442990
]
ASF GitHub Bot logged work on BEAM-10197:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jun/20 16:19
Start Date: 09/Jun/20 16:19
Worklog Time Spent: 10m
Work Description: udim commented on a change in pull request #11939:
URL: https://github.com/apache/beam/pull/11939#discussion_r436908464
##########
File path: sdks/python/apache_beam/typehints/typehints_test.py
##########
@@ -612,54 +613,70 @@ def test_match_type_variables(self):
hint.match_type_variables(typehints.Dict[int, str]))
-class SetHintTestCase(TypeHintTestCase):
+class BaseSetHintTest:
Review comment:
Nice solution! I've run into this in the past.
What's happening is that pytest is loading all modules and inspecting their
attributes looking for tests to run. Another solution solution would have been
to set `BaseSetHintTest = None` near the bottom of this module. Effectively
both solutions are hiding the base class from being collected by pytest.
##########
File path: sdks/python/apache_beam/typehints/typehints_test.py
##########
@@ -615,8 +615,8 @@ def test_match_type_variables(self):
class BaseSetHintTest:
class CommonTests(TypeHintTestCase):
- def __init__(self, string_type, py_type, beam_type, *args, **kwargs):
- super().__init__(*args, **kwargs)
+ def __init__(self, string_type, py_type, beam_type, method_name='runTest'):
Review comment:
This is fine, but I would leave this out. We don't use this feature
##########
File path: sdks/python/apache_beam/typehints/typehints_test.py
##########
@@ -615,8 +615,8 @@ def test_match_type_variables(self):
class BaseSetHintTest:
class CommonTests(TypeHintTestCase):
- def __init__(self, string_type, py_type, beam_type, *args, **kwargs):
- super().__init__(*args, **kwargs)
+ def __init__(self, string_type, py_type, beam_type, method_name='runTest'):
Review comment:
This is fine, but I would leave `method_name` out. We don't use this
feature
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 442990)
Time Spent: 3h (was: 2h 50m)
> Support type hints for frozenset
> ---------------------------------
>
> Key: BEAM-10197
> URL: https://issues.apache.org/jira/browse/BEAM-10197
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Saavan Nanavati
> Priority: P2
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Beam's internal typing system currently supports type hints for set but not
> frozenset.
>
> This Jira ticket will add type annotation support for both frozenset and
> typing.FrozenSet.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
