[
https://issues.apache.org/jira/browse/BEAM-10033?focusedWorklogId=446025&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-446025
]
ASF GitHub Bot logged work on BEAM-10033:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jun/20 18:58
Start Date: 15/Jun/20 18:58
Worklog Time Spent: 10m
Work Description: robinyqiu edited a comment on pull request #11957:
URL: https://github.com/apache/beam/pull/11957#issuecomment-644318238
Because of the problems mentioned above, I did not change the implementation
of `zetaSqlTypeToBeamFieldType`, instead I added another overload of it which
does not depend on Beam `fieldType`. It will allow compliance test driver to
call it (cl/316152825).
@apilloud Please check if this PR still LGTY.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 446025)
Time Spent: 1h (was: 50m)
> zetaSqlValueToJavaObject shouldn't take Field Type
> --------------------------------------------------
>
> Key: BEAM-10033
> URL: https://issues.apache.org/jira/browse/BEAM-10033
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql-zetasql
> Reporter: Andrew Pilloud
> Assignee: Robin Qiu
> Priority: P2
> Labels: beam-fixit
> Time Spent: 1h
> Remaining Estimate: 0h
>
> ZetaSQL Values contain a type, we don't use that type information when
> converting, instead we use the output schema.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
