reddycharan commented on a change in pull request #510: Issue-605 BP-15 New
CreateLedger API
URL: https://github.com/apache/bookkeeper/pull/510#discussion_r140858161
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
##########
@@ -853,9 +864,9 @@ public LedgerHandle createLedgerAdv(int ensSize, int
writeQuorumSize, int ackQuo
* Calls asynchronous version
*/
asyncCreateLedgerAdv(ensSize, writeQuorumSize, ackQuorumSize,
digestType, passwd,
- new SyncCreateCallback(), counter,
customMetadata);
+ new SyncCallbackUtils.SyncCreateCallback(),
counter, customMetadata);
Review comment:
nit: why do we have to provide full qualifying path -
SyncCallbackUtils.SyncCreateCallback(), SyncCallbackUtils class can be
imported, right?
same comment for other changes, as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
