reddycharan commented on a change in pull request #510: Issue-605 BP-15 New
CreateLedger API
URL: https://github.com/apache/bookkeeper/pull/510#discussion_r140884686
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerCreateOp.java
##########
@@ -200,4 +209,220 @@ private void createComplete(int rc, LedgerHandle lh) {
cb.createComplete(rc, lh, ctx);
}
+ private static final byte[] EMPTY_PASSWORD = new byte[0];
+
+ public static class CreateBuilderImpl implements CreateBuilder {
+
+ private final BookKeeper bk;
+ private int builderEnsembleSize = 3;
+ private int builderAckQuorumSize = 2;
+ private int builderWriteQuorumSize = 2;
+ private byte[] builderPassword = EMPTY_PASSWORD;
+ private org.apache.bookkeeper.client.api.DigestType builderDigestType
+ = org.apache.bookkeeper.client.api.DigestType.CRC32;
+ private Map<String, byte[]> builderCustomMetadata =
Collections.emptyMap();
Review comment:
in the existing implementation default custommetadata value is null, have
you verified if null and emptymap are equivalent in all places where metadata
is handled?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
