eolivelli commented on a change in pull request #510: Issue-605 BP-15 New
CreateLedger API
URL: https://github.com/apache/bookkeeper/pull/510#discussion_r140980149
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
##########
@@ -628,6 +690,22 @@ public long addEntry(byte[] data) throws
InterruptedException, BKException {
return addEntry(data, 0, data.length);
}
+ @Override
+ public CompletableFuture<Long> append(ByteBuffer data) {
Review comment:
client.api is a totally new API, clients will never see the old messy API.
ReadOnlyLedgerHandle extends LedgerHandle and this does not make sense, it has
addEntry methods for instance.
I think we should leave the old API as it is now and work on a new clean API
(see comments above)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
