eolivelli commented on a change in pull request #510: Issue-605 BP-15 New CreateLedger API URL: https://github.com/apache/bookkeeper/pull/510#discussion_r142375550
########## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/BookKeeperBuilder.java ########## @@ -0,0 +1,44 @@ +/* + * Copyright 2017 The Apache Software Foundation. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.bookkeeper.client.api; + +import org.apache.bookkeeper.client.BKException; + +/** + * BookKeeper Client Builder to build client instances. + */ +public interface BookKeeperBuilder { + + /** + * Configure the bookkeeper client with a provided component. + * + * @param component an external component to inject into the newly created BookKeeper clien + * + * @return client builder. + * + */ + BookKeeperBuilder with(Object component); Review comment: I will add explicit methods. I wanted to have a neutral way to inject components. For instance I would like not to have an explicit dependency to ZooKeeper for new clients in the builder. In the future I would like to have a way to set ZKClientConfig. I see that this way is not very clear for the user. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
