yzang commented on a change in pull request #521: Issue 520: Add more http endpoint URL: https://github.com/apache/bookkeeper/pull/521#discussion_r142017226
########## File path: bookkeeper-http/twitter-http-server/src/main/java/org/apache/bookkeeper/http/twitter/TwitterHttpHandlerFactory.java ########## @@ -0,0 +1,268 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + * + */ +package org.apache.bookkeeper.http.twitter; + +import com.twitter.finagle.http.Request; +import com.twitter.finagle.http.Response; +import com.twitter.util.Future; + +import org.apache.bookkeeper.http.AbstractHttpHandlerFactory; +import org.apache.bookkeeper.http.HttpServiceProvider; + + + +/** + * Factory which provide http handlers for TwitterServer based Http Server. + */ +public class TwitterHttpHandlerFactory extends AbstractHttpHandlerFactory<TwitterAbstractHandler> { Review comment: Yeah, the idea is same as stats provider, we can keep different implementations. We do introduce twitter-server in that module, but the dependency wouldn't be added unless we configure to use twitter http server when we build the project. I think another concern here might be whenever we add/remove a Http Api Endpoint, we need to make a few changes to both TwitterServer and Vertx. Maybe there's something we can improve here, like introduce another abstraction so that we don't have to implement a new method for a new http endpoint. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
