yzang commented on a change in pull request #521: Issue 520: Add more http endpoint URL: https://github.com/apache/bookkeeper/pull/521#discussion_r142017593
########## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/http/GetLedgerMetaService.java ########## @@ -0,0 +1,93 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + * + */ +package org.apache.bookkeeper.http; + +import static com.google.common.base.Charsets.UTF_8; + +import com.google.common.base.Preconditions; +import com.google.common.collect.Maps; +import java.util.Map; +import org.apache.bookkeeper.client.LedgerMetadata; +import org.apache.bookkeeper.conf.ServerConfiguration; +import org.apache.bookkeeper.http.service.HttpEndpointService; +import org.apache.bookkeeper.http.service.HttpServiceRequest; +import org.apache.bookkeeper.http.service.HttpServiceResponse; +import org.apache.bookkeeper.meta.LedgerManager; +import org.apache.bookkeeper.meta.LedgerManagerFactory; +import org.apache.bookkeeper.util.JsonUtil; +import org.apache.bookkeeper.zookeeper.ZooKeeperClient; +import org.apache.zookeeper.ZooKeeper; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * HttpEndpointService that handle Bookkeeper Configuration related http request. + */ +public class GetLedgerMetaService implements HttpEndpointService { + + static final Logger LOG = LoggerFactory.getLogger(GetLedgerMetaService.class); + + protected ServerConfiguration conf; + + public GetLedgerMetaService(ServerConfiguration conf) { + Preconditions.checkNotNull(conf); + this.conf = conf; + } + + @Override + public HttpServiceResponse handle(HttpServiceRequest request) throws Exception { + HttpServiceResponse response = new HttpServiceResponse(); + Map<String, String> params = request.getParams(); + + if (HttpServer.Method.GET == request.getMethod() && (params != null) && params.containsKey("ledger_id")) { + Long ledgerId = Long.parseLong(params.get("ledger_id")); + + ZooKeeper zk = ZooKeeperClient.newBuilder() Review comment: I'm seeing ZooKeeper appears at multiple services, and connecting ZK for each HTTP request is probably expensive. Shall we actually create a zk client in BKServiceProvider so that we don't have to build a ZK client each time we get a Http Request? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
