sijie commented on issue #510: Issue-605 BP-15 New CreateLedger API URL: https://github.com/apache/bookkeeper/pull/510#issuecomment-333950084 >Using Mockito and a new Utility class > It is not very clear to me how to do better then this final proposal, I have added two new utility > methods to MockBookKeeperTestCase since your did your review I see there are multiple mock functions on mocking ledger metadata and the write & read functions. I think those functions can become util functions. I am fine with current mock util. we can improve it later. > Checkstyle > I found checkstyle was not present in bookkeeper-server module. After this patch we will have > checkstyle in new api package, other packages do not work for me. I think @jiazhai attempts to enable checkstyle for some packages. but it doesn't seem the pom file was updated. I would suggest having a separate pull request to enable checkstyle first, because the suppression file was already there. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
