sijie commented on issue #510: Issue-605 BP-15 New CreateLedger API URL: https://github.com/apache/bookkeeper/pull/510#issuecomment-333950932 @eolivelli sorry for being paranoid about this interface and also the test cases. because if the interface is checked in, it is hard to change in future without breaking backward compatibility. so I would like to spend more time to make sure we don't have to carry a lot of legacy stuffs. for the test cases, I am strongly in favor of using mockito whenever we can, otherwise it would introduce another potential flaky test. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
